⭐ Add support for additional operating systems to rsyslog resource#6661
Merged
⭐ Add support for additional operating systems to rsyslog resource#6661
Conversation
tas50
changed the title
Contributor
Test Results5 130 tests 5 126 ✅ 1m 59s ⏱️ Results for commit b2bbe01. ♻️ This comment has been updated with latest results. |
Make sure this works outside Linux Signed-off-by: Tim Smith <tsmith84@gmail.com>
Member
Author
|
/review |
mondoo-code-review
bot
dismissed
their stale review
Superseded by new review
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
Comment on lines
+36
to
+39
| t.Run("nil platform", func(t *testing.T) { | ||
| conn := &mockConn{asset: &inventory.Asset{}} | ||
| assert.Equal(t, "/etc/rsyslog.conf", rsyslogConfPath(conn)) | ||
| }) |
There was a problem hiding this comment.
🔵 suggestion — You test nil Platform but not nil Asset. Consider adding a case with &mockConn{asset: nil} to cover the asset != nil guard in rsyslogConfPath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure this works outside Linux